rubyforgood/human-essentials

Include inactive items in distribution reports

Open

#4,517 opened on Jul 14, 2024

View on GitHub
 (32 comments) (0 reactions) (0 assignees)Ruby (576 forks)github user discovery
Good First Issuestale

Repository metrics

Stars
 (571 stars)
PR merge metrics
 (Avg merge 90d 16h) (22 merged PRs in 30d)

Description

Summary

Include inactive items in reports of items that have been distributed

Why

Accuracy -- any now-inactive items that were distributed were, indeed, distributed!

Details

Currently, inactive items are included in the distribution totals in the distribution index, but not in the distributions reports (under Reports, when you are logged in as org_admin1@example.com). These reports include Distribution by County and Itemized distributions

Criteria for completion

  • Inactive items included in Distribution by County report
  • Inactive items included in Itemized Distributions report
  • Test to demonstrate this is so

Contributor guide

Research direction
Inspect the existing report generation queries (likely in Rails models or controllers) and modify them to include inactive items by removing or adjusting the active only filter. Write tests to confirm inactive items appear in Distribution by County and Itemized Distributions reports.
Tech stack
ruby
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60