Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Start with lib/forwardable.rb around line 238 and compare its call with ferrum's lib/ferrum/page/screenshot.rb definition of pdf(**opts). Read the Ruby 2.7 keyword-argument warning in the reported execution path. Done means identifying which call site needs adjustment and confirming that the warning no longer appears.
Written by the indexing model from the issue text.
Description
Hello.
I see ruby2_keywords usage, but I'm getting such warnings for some reason in my project:
/home/alex/Projects/ruby/forwardable/lib/forwardable.rb:238: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/home/alex/.rbenv/versions/2.7.1/lib/ruby/gems/2.7.0/gems/ferrum-0.9/lib/ferrum/page/screenshot.rb:35: warning: The called method `pdf' is defined here
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]
I see this referenced source: https://github.com/rubycdp/ferrum/blob/6906d98/lib/ferrum/page/screenshot.rb#L35
def pdf(**opts)
What changes are expected and where?
- Dominant language
- Ruby
- Stars
- 46
- Forks
- 16
- Avg merge
- 3m
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ruby/forwardable
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
ruby/forwardable#61 ·
-
Broken link Openbug
Difficulty 1/5 Under an hour Newbie friendliness 55/100
ruby/forwardable#42 ·
-
Broken link Openbug
Difficulty 1/5 Under an hour Newbie friendliness 55/100
ruby/forwardable#41 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
ruby/forwardable#12 · 4 comments ·
All issues in ruby/forwardable
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
riscv/riscv-unified-db#2626 ·
-
Component: GLib
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
ds-drift
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
we-promise/sure#3693 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
simp/pupmod-simp-simp#395 ·