Empty entity is exposing a field

Open
#230 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
ruby
Domain
api

Research direction

Start by reproducing the empty Project < Grape::Entity case on grape-entity 0.5.1 and trace how the JSON response exposes the permissions field. Done means an entity with no declared fields emits no unexpected permissions data, with a regression test covering the reported response.

Written by the indexing model from the issue text.

Description

bug?

I have the following empty entity:

class Project < Grape::Entity
end

Although the entity is empty the JSON response contains a field permission:

{
  "permissions": {
    "project_access": null,
    "group_access": {
      "access_level": 50,
      "notification_level": 3
    }
  }
}

This seems very strange to me and I think that is a bug. I am using grape-entity 0.5.1.

Dominant language
Ruby
Stars
729
Forks
154
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from ruby-grape/grape-entity

All issues in ruby-grape/grape-entity

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.