rtk-ai/rtk

RTK parse failures in grep

Open

#880 opened on Mar 27, 2026

View on GitHub
 (5 comments) (1 reaction) (0 assignees)Rust (48,085 stars) (2,914 forks)batch import
bugeffort-smallfilter-qualitygood first issue

Description

OS: MacOS rtk version: 0.34.0

I recently did a code review with RTK enabled and noticed this output:

───────────────────────────────────────────────────────────────────────
  #  Command                   Count  Saved    Avg%    Time  Impact
───────────────────────────────────────────────────────────────────────
 1.  rtk ls                       49   5.9K   67.5%     2ms  ██████████
 2.  rtk grep                      4    256   28.7%     2ms  ░░░░░░░░░░
 3.  rtk git status                2    132   76.7%    28ms  ░░░░░░░░░░
 4.  rtk find                      2     23   46.0%    10ms  ░░░░░░░░░░
 5.  rtk fallback: grep -r...      1      0    0.0%    58ms  ░░░░░░░░░░
 6.  rtk fallback: grep -r...      1      0    0.0%    26ms  ░░░░░░░░░░
 7.  rtk fallback: grep -r...      1      0    0.0%    26ms  ░░░░░░░░░░
 8.  rtk fallback: grep -r...      1      0    0.0%    29ms  ░░░░░░░░░░
 9.  rtk fallback: grep -r...      1      0    0.0%    28ms  ░░░░░░░░░░
10.  rtk fallback: grep -r...      1      0    0.0%    21ms  ░░░░░░░░░░

Looks like a bunch of greps failed. Digging futher:

[pp@mbp:~/fiddle/zmNinjaNG]$ rtk gain -F
RTK Parse Failures
════════════════════════════════════════════════════════════

Total failures:    65
Recovery rate:     100.0%

Top Commands (by frequency)
────────────────────────────────────────────────────────────
     2x  grep -rn dangerouslySetInnerHTML /Users/pp/f...
     1x  grep -rn zmng_crypto_salt_v1\|getPersistentSalt...
     1x  grep -rn window\.open /Users/pp/fiddle/zmNin...
     1x  grep -rn window\.location\s*= /Users/pp/fidd...
     1x  grep -rn window\.location\.href\s*= /Users/pp..
     1x  grep -rn window\.location /Users/pp/fiddle/z...
     1x  grep -rn truncate --include=*.tsx
     1x  grep -rn token= /Users/pp/fiddle/zmNinjaNG/a...
     1x  grep -rn token /Users/pp/fiddle/zmNinjaNG/ap...
     1x  grep -rn toast\.\(error\|success\|warning\|info...

Recent Failures (last 10)
────────────────────────────────────────────────────────────
  2026-03-27T12:44 [ok] grep -rn LogLevel\.ERROR /Users/pp...
  2026-03-27T12:44 [ok] grep -rn log\.auth.*receivedData\|rec...
  2026-03-27T12:44 [ok] grep -rn receivedData: response\.data...
  2026-03-27T12:44 [ok] grep -rn log\.kiosk\b /Users/pp/fi...
  2026-03-27T12:43 [ok] grep -rn sanitize\|sanitizeObject\|sa...
  2026-03-27T12:43 [ok] grep -rn \.connect( /Users/pp/fidd...
  2026-03-27T12:43 [ok] grep -rn notification.*password\|pass...
  2026-03-27T12:43 [ok] grep -rn \.connect( /Users/pp/fidd...
  2026-03-27T12:43 [ok] grep -rn \.password\b /Users/pp/fi...
  2026-03-27T12:43 [ok] grep -rn CSRF\|csrf\|X-CSRF\|SameSite...

Running rtk grep -rn LogLevel\.Error from CLI works fine

Contributor guide

Tech stack
rust
Domain
cliperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of grep command syntaxKnowledge of Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue shows that certain `grep` commands fail to parse and fall back to direct execution. The user reports that `rtk grep rn LogLevel\.Error` works from CLI but appears in parse failures. Investigate the grep command parsing logic in the RTK codebase, likely found in the parser or tokenizer module. Reproduce the failure with patterns containing special characters like `\.` or `\|`. Examine the 'rtk gain F' output to identify patterns causing failures. Check if the issue is related to escape sequence handling or regex syntax. Consider running the test suite for grep parsing and look for recent changes.