rtk-ai/rtk

xfailed tests reported as '1 failed' in summary output

Open

#672 opened on Mar 18, 2026

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (48,085 stars) (2,914 forks)batch import
bugeffort-smallfilter-qualitygood first issue

Description

Description

When running pytest through the rtk proxy, tests marked with xfail (expected failure) are reported as "1 failed" in the rtk summary line, even though pytest itself reports them as xfailed (which is a pass, not a failure).

Reproduction

# Direct pytest output (correct):
3711 passed, 8 deselected, 1 xfailed in 10.01s

# rtk proxy summary (incorrect):
Pytest: 3711 passed, 1 failed

Expected behavior

The rtk summary should either:

  • Report xfailed tests as passed (since they are expected failures), or
  • Show them separately as 1 xfailed (matching pytest's own reporting)

Environment

  • rtk version: latest
  • pytest with @pytest.mark.xfail decorated tests

Contributor guide

Tech stack
rust
Domain
clitesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Rust knowledgeunderstanding of pytest xfail
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine rtk's pytest proxy code, particularly the summary output generation. Look for how test results are parsed and reported. The issue mentions the summary line reports '1 failed' instead of '1 xfailed'. Check if there is a mapping of test outcomes that incorrectly treats xfail as failure. Potential file: src/proxy/pytest.rs or similar.
xfailed tests reported as '1 failed' in summary output · rtk-ai/rtk#672 | Good First Issue