rtk-ai/rtk

bug: npm rule in rewrite registry misses install — filter already exists in npm_cmd.rs

Open

#1148 opened on Apr 10, 2026

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (48,085 stars) (2,914 forks)batch import
bugeffort-smallfilter-qualitygood first issue

Description

Bug

The npm rewrite rule in src/discover/rules.rs only matches run|exec:

pattern: r"^npm\s+(run|exec)",

This means npm install (and npm ci, npm list, npm outdated, etc.) are never rewritten by the hook, so they bypass RTK entirely.

The filter already handles it

src/cmds/js/npm_cmd.rs has full install support — filter_npm_output() strips progress bars and keeps the summary. The NPM_SUBCOMMANDS const lists 30+ subcommands including install, ci, list, outdated, audit, etc.

The rule just doesn't route them there.

Reproduction

$ rtk rewrite "npm install"; echo "exit: $?"
# exit: 1  (no match — falls through uncompressed)

Suggested fix

// rules.rs line 56
pattern: r"^npm\s+(run|exec|install|ci|list|ls|outdated|audit|test)",

Environment

  • rtk 0.35.0
  • macOS Apple Silicon
  • rtk discover shows 43 npm install calls with 0% savings

Contributor guide

Tech stack
rustnodejs
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust basicsRegular expressionsnpm CLI usage
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The bug is in `src/discover/rules.rs` where the regex pattern only matches `npm run|exec`. The fix should update the pattern to include subcommands like `install`, `ci`, `list`, etc., which are already handled by `filter npm output()` in `src/cmds/js/npm cmd.rs`. Review the existing `NPM SUBCOMMANDS` constant in that file to ensure comprehensive coverage. No linked PRs or maintainer responses are present, so the fix is straightforward.