rtfeldman/seamless-immutable

Fix tests that relied on Lodash 4

Open

#179 opened on Dec 11, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (221 forks)batch import
help wanted

Repository metrics

Stars
 (5,367 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I mistakenly upgraded our tests to use Lodash 4, not realizing some of the features in Lodash 4 did not work in IE9-10. (seamless-immutable itself does not depend on Lodash; this was for tests only.)

We subsequently added tests that relied on those features, causing IE9-10 tests to fail. I have reverted to Lodash 3.10 and disabled those tests, so that the other tests can complete cross-browser testing as normal. However, now we have a few pending tests that need to be rewritten to use Lodash 3.10 features instead of the Lodash 4 features they currently use.

The pending tests are marked with xit in the test suite.

Help on this would be greatly appreciated! ❤️

Contributor guide

Research direction
Find all test cases marked with `xit` in the test suite and rewrite them to use Lodash 3.10 features instead of Lodash 4 features. Refer to Lodash 3.10 documentation for equivalent methods.
Tech stack
javascript
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75