rtfeldman/seamless-immutable

Does not work with Javascript Maps

Open

#171 opened on Nov 14, 2016

View on GitHub
 (9 comments) (0 reactions) (0 assignees)JavaScript (5,367 stars) (221 forks)batch import
enhancementhelp wanted

Description

I am using a javacript map to store data I retrieve from an api for a udacity project.

However, the data is not being saved to the immutable object.

here is a branch you can clone and verify:

  1. clone https://github.com/noahehall/udacity-trainschedule/tree/serviceworkers
  2. npm install
  3. npm run start

here is picture of implementation

here is picture of error received from immutable error TypeError: immutableDoesNotWorkWithJavascriptMaps.data.has is not a function(…)

Is there a workaround to get immutable to use Javascript maps? am i doing something wrong (very likely...)? or should I abandon seamless immutable?

Contributor guide

Tech stack
javascript
Domain
data
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptMap objectimmutable data concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests support for JavaScript Map objects in seamless immutable. Currently, the library only handles plain objects and arrays. To implement, examine the immutable wrapper pattern for objects (e.g., overriding get, set, etc.) and adapt it for Map. The user provided a reproduction branch (https://github.com/noahehall/udacity trainschedule/tree/serviceworkers). Review comments for any maintained guidance. The fix would involve creating an ImmutableMap class that mirrors the API but uses Map's internal storage.