rstudio/shiny

Printing within Chrome causes href to be displayed on download button

Open

#2,447 opened on May 24, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)R (5,649 stars) (1,890 forks)batch import
Effort: LowHelp WantedPriority: LowType: Bug :bug:

Description

System details

Browser Version: Chrome (only one tested)

Example application or steps to reproduce the problem

Screen Shot 2019-05-24 at 2 37 31 PM

Describe the problem in detail

Community post: https://community.rstudio.com/t/download-button-appears-with-session-information-when-printing-paper/30873

Known fix: https://stackoverflow.com/questions/7301989/need-to-remove-href-values-when-printing-in-chrome

@media print {
  a[href]:after {
    content: none !important;
  }
}

Contributor guide

Tech stack
rcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic CSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The fix is a CSS media query to hide href content in print mode. Locate the Shiny package's CSS file (likely shiny/www/shared/shiny.css) and add `@media print { a[href]:after { content: none !important; } }`. Confirm that the fix resolves the issue by printing a Shiny app with download buttons.