rstudio/plumber

Parse parameters if a OpenAPI type is specified

Open

#762 opened on Feb 5, 2021

View on GitHub
 (8 comments) (1 reaction) (0 assignees)R (1,437 stars) (257 forks)batch import
help wanted

Description

Fixes #755

Would need to undo https://github.com/rstudio/plumber/pull/756 , but it is fair that this be the default behavior.

If nothing is specified, then no type conversion should be attempted.

Contributor guide

Tech stack
None
Domain
api
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
R programmingOpenAPI specificationPlumber package internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review the OpenAPI type parsing in plumber, especially the current parameter handling. Examine issue #755 and PR #756 which this issue references. The maintainers suggest undoing PR #756; understand why and how to reimplement parameter conversion only when an OpenAPI type is specified. Look at the plumber source code for parameter parsing and type conversion functions.