rstudio/learnr

Favicons

Open

#245 opened on Jun 26, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)R (240 forks)github user discovery
help wantedpriority: lowtype: bug

Repository metrics

Stars
 (734 stars)
PR merge metrics
 (PR metrics pending)

Description

Would it be possible to include a custom favicon for learnr through the www/favicon.ico directory, such as for a shiny application?

Of note: The standard "header includes" pattern works for regular Rmd and runtime: shiny but not for runtime: shiny_prerendered (documents published to an RStudio Connect server)

  • Successful:
---
title: "Shiny Runtime Favicon Test"
output: 
  html_document:
    includes:
      in_header: "favicon.html"
runtime: shiny
---
  • Unsuccessful:
---
title: "Learnr Favicon Test"
output: 
  learnr::tutorial:
    includes:
      in_header: "favicon.html"
runtime: shiny_prerendered
---

Contributor guide

Research direction
Investigate how learnr handles header includes for shiny prerendered runtime and compare with shiny runtime to identify the missing implementation for favicons.
Tech stack
r
Domain
web dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RHTML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75