rsmbl/Resemble.js

Error checking?

Open

#85 opened on Oct 17, 2016

View on GitHubContributor guide
 (0 comments) (3 reactions) (0 assignees)JavaScript (433 forks)batch import
Feature requestHelp wanted

Repository metrics

Stars
 (4,364 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

There should be an onError() or something. I'm passing in image buffers but I never get into the onComplete callback. I've got no way of knowing what went wrong.

Contributor guide

Research direction
Examine the current API and identify where errors from image processing might be swallowed. Look for a way to add an optional onError callback parameter to the comparison functions.
Tech stack
javascript
Domain
web dev
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55