rsmbl/Resemble.js

Ignoring antialiasing does not work correctly

Open

#151 opened on Sep 5, 2018

View on GitHubContributor guide
 (7 comments) (0 reactions) (0 assignees)JavaScript (433 forks)batch import
BugGood first issue

Repository metrics

Stars
 (4,364 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hello guys.

How do you think these images are equivalent if you want to ignore antialiasing?

resemble js image analysis 2018-09-05 19-12-43

Expected behaviour: comparison with tolerance 2.3 and with ignore antialiasing

Contributor guide

Research direction
Trace the antialiasing comparison logic in the codebase and identify where the tolerance is not being applied correctly.
Tech stack
javascript
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50