rpgtex/DND-5e-LaTeX-Template

Monster attack helper assumes English grammar

Open

#190 opened on Feb 14, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TeX (1,601 stars) (333 forks)batch import
help wanted

Description

Raised in https://github.com/rpgtex/DND-5e-LaTeX-Template/pull/189#issuecomment-463186495:

Our captions assume the damage type precedes the word for "damage". This is not the case in French (and other Romance languages). For example, "bludgeoning damage" is « dégâts contondants ».

Currently, users can hack around this by setting \damagename to an empty string and passing in the full string:

\monsterattack[..., dmgtype=dégâts contondants]

It'd be nice if we could come up with a grammatically correct general solution for all localizations. However, defining strings for each damage type may be the only way to accomplish this. The downside of that approach is users would need to pass in the caption macro, or an English name for the damage:

\DndMonsterAttack[..., dmg-type=\piercingdamagename]
\DndMonsterAttack[..., dmg-type=piercing]  % would call \piercingdamagename internally

Contributor guide

Tech stack
None
Domain
localization
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
LaTeX macro knowledgeLocalization concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate how \damagename is currently used in monster attacks. Review the discussion in PR #189 for context. Consider defining per damage type localization macros (e.g., \piercingdamagename) and modifying \monsterattack to accept a damage type key that automatically selects the correct localized string.