roughike/BottomBar

BottomBar behind navBar

Open

#434 opened on Aug 24, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (8,411 stars) (1,551 forks)batch import
help wantedv2

Description

Updated 29/08/2016 - layout code

Hi, thanks for your work roughike your update is awesome. I just have a little issue, the bottomBar stay hidden behind the navBar even if i'm not using the "underNavBar" behavior, I would like to put it at the top of the navBar. I tried to use fitsSystemWindows with no success.

Update : The BottomBar is inside a Fragment

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
    android:orientation="vertical"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    xmlns:app="http://schemas.android.com/apk/res-auto"
>
        <com.roughike.bottombar.BottomBar
            android:id="@+id/bottomNavigation"
            android:layout_width="match_parent"
            android:layout_height="60dp"
            android:layout_alignParentBottom="true"
            app:bb_tabXmlResource="@xml/bottom_navigation_tabs"
            app:bb_activeTabColor="@color/colorAccent"
        >
    </com.roughike.bottombar.BottomBar>
</LinearLayout>

bottombarbehindnavbar

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Android layout basicsXMLFragment lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the layout code provided. The BottomBar is inside a Fragment. The issue is that the BottomBar appears behind the navigation bar even though the behavior is not set to 'underNavBar'. The user tried fitsSystemWindows without success. Possible solutions include adjusting the BottomBar's layout parameters or handling system window insets properly in the Fragment. Check the BottomBar library source code (e.g., BottomBar.java) for how it handles insets and whether there is a known issue with fragment based layouts.