ropensci/visdat

make `vis_guess` fast

Open

#14 opened on Mar 6, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)R (47 forks)github user discovery
Priority 2enhancementhelp wantedmaintenance

Repository metrics

Stars
 (462 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Currently vis_guess is a bit slow and it'd be nice to make it faster.

We found that using vapply was much faster than using purrr, which is a bit of a shame as I think that the current code doesn't read as nice as purrr code (dare I say it, it doesn't purrr).

The way I see it we have two options to really speed things up.

  1. Write some C++ code based on the readr::::CollectorGuess code, so that it deals with a vector, rather than a single element.
  2. Use one of the functions from the parallel library, like mcapply.

Contributor guide

Research direction
Profile the current `vis guess` function to identify bottlenecks. Consider implementing a C++ version using Rcpp for vectorized guessing, or explore parallelization with `parallel` package functions like `mclapply`. Benchmark the improvements against the current implementation.
Tech stack
rcpp
Domain
data visualizationperformance
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60