ronggang/transmission-web-control

inline styles and scripts

Open

#379 opened on Feb 22, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)CSS (777 forks)batch import
help wanted

Repository metrics

Stars
 (4,716 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

如果反馈BUG，请提供以下信息，如果可能，同时提供英文描述，谢谢。

  • Transmssion 版本:
  • Tr Web Control 版本:
  • 浏览器名称及版本：
  • 问题描述:

For English User

Please provide the following information.

  • Transmssion version: 2.94 (d8e60ee44f), RPC: 15
  • Tr Web Control version: 1.6.0 beta (20180906)
  • Browser name & version：Chrome, Firefox
  • Problem description: There are a lot of inline styles and scripts. I am using very strict CSP that does not allow unsafe-inline content and the UI appears all wrong. It would be nice to break everything that is written inline to separate files. image

Contributor guide

Research direction
Identify all inline style attributes and script event handlers in HTML files. Use grep to find patterns like 'style="', 'onclick=', 'onload=', etc. Move inline CSS to external stylesheets and inline JavaScript to external script files. Update CSP headers to allow external resources.
Tech stack
javascriptcsshtml
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65