rome/tools

馃搸 `useForOf`, prefer-for-of, @typescript-eslint/prefer-for-of

Open

#4,174 opened on Jan 24, 2023

View on GitHub
聽(2 comments)聽(0 reactions)聽(0 assignees)Rust聽(23,438 stars)聽(647 forks)batch import
A-LinterHelp wantedI-Normalgood first issuetask

Description

Description

https://typescript-eslint.io/rules/prefer-for-of

This rule forces loop functions to use for of if the index of a for loop is never used, greatly improving readability and ensuring there are no unused variables being referenced (in this case, the index variable).

Contributor guide

Tech stack
typescriptjavascript
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingRome lint framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The rule should replicate the behavior of @typescript eslint/prefer for of. It detects for loops where the index variable is only used to access array elements, suggesting for of instead. To implement, examine existing Rome lint rules (e.g., in crates/rome js analyze/src/analyzers/) for pattern. The rule should be added to the JS/TS analyzer. Check the Rome contributor guide for adding a new rule.
馃搸 `useForOf`, prefer-for-of, @typescript-eslint/prefer-for-of 路 rome/tools#4174 | Good First Issue