rome/tools

☂️ CSS support

Open

#2,350 opened on Apr 5, 2022

View on GitHubContributor guide
 (8 comments) (17 reactions) (1 assignee)Rust (647 forks)batch import
A-LSPA-ParserHelp wantedL-CSSumbrella

Repository metrics

Stars
 (23,438 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Description

We are going to use this issue to track the various work around CSS. We don't plan, for the time being, to support super languages, although we might think about preparing the infrastructure to be able to support them.

PREVIOUS DISCUSSIONS: https://github.com/rome/tools/issues/984

  • create a css.ungram file where we will slowly implement new grammars
  • create a rome_css_syntax crate, where we will have all things related to the CSS syntax, generated code too
  • expand the codegen of the grammar to include CSS too
  • evaluate how to implement the parser, lexer, etc. (it will require a separate discussion)
  • create a rome_css_formatter crate
  • make the rome_formatter generic
  • prepare the Rome architecture to include CSS (file handlers, capabilities, etc.)
  • add support for CSS inside the VSCode extension

Contributor guide

Research direction
Study Rome's existing plugin architecture and how JavaScript parsing/formating works, then design a similar structure for CSS. Start by implementing a CSS ungram file and syntax crate, then expand the code generation.
Tech stack
rust
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
RustCSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30