robotframework/SeleniumLibrary

alert issue in acceptance tests

Open

#1,349 opened on Mar 20, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (1,252 stars) (714 forks)batch import
help wantedpriority: mediumtask

Description

I just withnessed following issue:

Running Acceptance . Keywords . Alerts . Alert Should Not Be Present with custom timeout left a alert open after a test failure and that caused a trickle down effect of quite a lot of tests failing due to following error:

UnexpectedAlertPresentException: Alert Text: None Message: unexpected alert open: {Alert text : Alert after 500ms!} (Session info: chrome=72.0.3626.121) (Driver info: chromedriver=2.46.628411 (3324f4c8be9ff2f70a05a30ebc72ffb013e1a71e),platform=Mac OS X 10.14.3 x86_64)

Maybe the alert tests should have test suite and teardown to open & close the browser to avoid this sort of flakyness ?

Contributor guide

Tech stack
python
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Robot FrameworkSeleniumLibraryPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue describes a flaky test where an alert remains open after a failure, causing subsequent tests to fail. The suggested fix is to add a test suite teardown that closes the browser after each test suite. To implement, examine the acceptance test files in the repository, likely under 'atest/acceptance/'. Look for existing suite teardown patterns in other test files and add a teardown that closes the browser to the alert tests. Ensure the teardown runs even on test failure. Refer to the Robot Framework documentation for suite teardowns.
alert issue in acceptance tests · robotframework/SeleniumLibrary#1349 | Good First Issue