rmax/scrapy-redis

Logs report a warning: Spider.make_requests_from_url method is deprecated...

Open

#181 opened on Dec 11, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (1,586 forks)batch import
help wantedimprovement

Repository metrics

Stars
 (5,337 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Environments : scrapy-redis 0.6.8, Scrapy 2.4.1, Python 3.8.5 When running the spider, the logs report a warning : Spider.make_requests_from_url method is deprecated: it will be removed and not be called by the default Spider.start_requests method in future Scrapy releases. Please override Spider.start_requests method instead. Warning is from line 66 in https://github.com/scrapy/scrapy/blob/master/scrapy/spiders/__init__.py, the reason may be in https://github.com/rmax/scrapy-redis/blob/master/src/scrapy_redis/spiders.py, method named make_request_from_data in line 121. Can this warning be fixed?

Contributor guide

Research direction
Modify the `make request from data` method in `scrapy redis/spiders.py` to override `start requests` instead, following Scrapy's deprecation path.
Tech stack
pythonredis
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonScrapy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60