rjsf-team/react-jsonschema-form

Tests for experimental_customMergeAllOf

Open

#4385 opened on Nov 18, 2024

View on GitHub
 (3 comments) (0 reactions) (1 assignee)TypeScript (13,175 stars) (2,136 forks)batch import
bughelp wanted

Description

Prerequisites

What theme are you using?

utils

Version

5.x

Current Behavior

The experimental_customMergeAllOf feature was introduced in https://github.com/rjsf-team/react-jsonschema-form/pull/4308. Later, I discovered some missing code branches and fixed them in https://github.com/rjsf-team/react-jsonschema-form/pull/4383.

Following a discussion, we agreed it would be valuable to test whether all functions successfully propagate experimental_customMergeAllOf.

This issue aims to explore the possibility of writing such tests.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Anything else?

No response

Contributor guide

Tech stack
reacttypescriptjest
Domain
frontendtesting
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScripttesting experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review PR #4308 and #4383 to understand the `experimental customMergeAllOf` feature and the missing code branches that were fixed. The goal is to write tests that verify all functions in the schema merge logic correctly propagate this experimental option. Focus on the utils package and the mergeAllOf utility. The linked discussion in PR #4383 provides context on what tests are needed.