rjsf-team/react-jsonschema-form

Recurring indexed titles in array items for themes other than core

Closed

#4,011 opened on Dec 23, 2023

View on GitHubContributor guide
 (2 comments) (0 reactions) (1 assignee)TypeScript (2,136 forks)batch import
bughelp wanted

Repository metrics

Stars
 (13,175 stars)
PR merge metrics
 (Avg merge 3d 17h) (32 merged PRs in 30d)

Description

Prerequisites

What theme are you using?

mui

Version

5.15.1

Current Behavior

The indexed titles which are handed down from the array property to its children are recurring for non core themes. For example, in this playground, the title/label array-1 is being used at two places.

Expected Behavior

The indexed titles should not repeat, similar to how the core theme works.

Steps To Reproduce

  1. Head to the playground example
  2. Notice that array-1 title/label is being repeated for both the first and second index

Environment

- Chrome: 120.0.6099.71

Anything else?

This is happening after a recent https://github.com/rjsf-team/react-jsonschema-form/pull/4002 PR. The indexed titles were taken care of for the core theme and are required for other themes as well.

Contributor guide

Research direction
The issue is about recurring indexed titles in array items for non core themes (e.g., MUI). PR #4002 fixed this for the core theme. The fix likely involves how titles are generated or passed to array items. To resolve, examine the changes in PR #4002 and identify where non core themes diverge. Look at the theme components' rendering of array items, especially how they handle the `title` prop and indexed labels. The playground links in the issue provide concrete examples to test. Check the theme files under `packages/theme *` for the relevant rendering logic.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Understanding of ReactBasic knowledge of JSON SchemaFamiliarity with PR #4002
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45