rjsf-team/react-jsonschema-form

Format time in compliance with Draft 7

Open

#3930 opened on Oct 30, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (13,175 stars) (2,136 forks)batch import
breaking changebughelp wanted

Description

Prerequisites

What theme are you using?

mui

Version

5.13.0

Current Behavior

The WidgetTime currently outputs time in the format 20:20:39 without including a timezone offset

Expected Behavior

According to JSON Schema Draft 7 compliance, the WidgetTime should output time with a timezone to be considered valid. The time format should include a timezone offset, something like 20:20:39+00:00

Steps To Reproduce

Use the playground

{
  "title": "Date and time widgets",
  "type": "object",
  "properties": {
    "time": {
      "type": "string",
      "format": "time"
    }
  }
}

Environment

- OS: MacOS 13.2.1
- Node: v16.20.2
- npm: 8.19.4

Anything else?

A quick solution is to override WidgetTime with a custom one.

Contributor guide

Tech stack
reacttypescriptnodejs
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactJSON Schematime formatting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the current WidgetTime implementation in the source code (likely under src/widgets). Understand how it renders time and where the value is processed. The expected fix is to append a timezone offset (e.g., +00:00) to comply with JSON Schema Draft 7. Consider whether to use the client's local timezone or allow configuration. Review any existing tests or related issues for guidance.