rjsf-team/react-jsonschema-form

if-then in allOf is not working when additionalProperties is set to false

Open

#3,251 opened on Nov 16, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (2,136 forks)batch import
any-one-all-ofbughelp wantedif-then-else

Repository metrics

Stars
 (13,175 stars)
PR merge metrics
 (Avg merge 3d 17h) (32 merged PRs in 30d)

Description

Prerequisites

What theme are you using?

core

Version

5.x

Current Behavior

Let's take an example: playground

The schema has "additionalProperties" set to false and "abc" enum property, then we have "allOf" section with 2 conditions for "abc", each of them should add some new, required property, but it is not rendering, unless "additionalProperties" is removed or set to true. Even though they are not shown, the validation is executed against them and it fails.

Expected Behavior

The schema from above should add properties that are conditionally configured in "allOf" section even when "additionalProperties" is set to false, so they can be filled.

Steps To Reproduce

  1. On this playground
  2. Select "value1" or "value2" in "abc" field
  3. Execute validation

Environment

- OS: Windows 10
- Browser: Chrome

Anything else?

No response

Contributor guide

Research direction
Examine the schema merging logic in the form library, specifically how allOf branches are combined with the base schema when additionalProperties is false. Look at the 'getMatchingOption' and 'resolveSchema' functions.
Tech stack
javascripttypescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JSON SchemaReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50