rjsf-team/react-jsonschema-form

Conditional property is not added to the form if its type conflicts with `additionalProperties`

Open

#3178 opened on Oct 5, 2022

View on GitHub
 (7 comments) (0 reactions) (1 assignee)TypeScript (13,175 stars) (2,136 forks)batch import
additionalPropertiesbughelp wantedif-then-else

Description

Prerequisites

What theme are you using?

core

Version

5.0.0-beta.10

Current Behavior

My schema should add a "string" field but it only does so when additionalProperties is

  • undefined
  • true (this is not a real workaround because of #3179)
  • `{ "type": "string" }

This warning is logged to the console when the field should be added:

could not merge subschemas in allOf:
Error: Could not resolve values for path:"properties.state.type". They are probably incompatible. Values: 
"string"
"number"

Expected Behavior

The conditional field should appear - I should be able to customize additionalProperties and have conditional fields that do not match the additionalProperties schema.

Steps To Reproduce

Link to reproduction in current playground

Environment

Playground 5.0.0-beta.10

Anything else?

No response

Contributor guide

Tech stack
reacttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJSON Schemareact jsonschema form basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the schema merging logic in the utils/schema/mergeSchemas.ts file, specifically how allOf subschemas interact with additionalProperties. The error log indicates a conflict between property types in conditional then schemas and additionalProperties. Look at the existing PR #3179 for related work and comments from maintainers to understand the intended fix.