rjsf-team/react-jsonschema-form

"Omit extra items" does not omit arrays in dependencies

Open

#1357 opened on Jul 13, 2019

View on GitHub
 (1 comment) (0 reactions) (1 assignee)TypeScript (13,175 stars) (2,136 forks)batch import
arraysbugdependencieshelp wanted

Description

Prerequisites

Description

Playground link

Steps to Reproduce

  1. Check "Omit extra data" and "Live omit"
  2. Click on "opt" to make it true
  3. Check "a" and "b"
  4. Click "opt" to make it false
  5. Check "c" and "d"

Expected behavior

When clicking "opt" to make it false, "a" and "b" should be omitted from the form data. I should end up with the form data's value of "arr" to equal ["c", "d"].

Actual behavior

"a" and "b" is not omitted from the form data. I end up with the form data's value of "arr" to equal ["a", "b", "c", "d"].

Version

1.6.1

Contributor guide

Tech stack
reactjavascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JSON Schema dependenciesreact jsonschema formJavaScript fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue suggests that the 'Omit extra items' feature fails for array fields within conditional dependencies. Focus on the code that handles schema dependencies and form data updates, particularly in utils.js where `mergeSchemas` or `resolveDependencies` functions reside. The playground link is provided for easy reproduction. Investigate how the `liveOmit` option triggers data removal and why arrays are not cleared when the dependency condition changes. There is an assignee but no linked PR, so the issue may be open for contribution.