rizinorg/cutter

Comments window should show unescaped comments whenever possible

Open

#2,961 opened on Jun 7, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (14,852 stars) (1,123 forks)batch import
good first issue

Description

See the comment at 0x1400022c6 address, it's a Chinese words 好的, which are shown in the disassembly but neither in Cutter nor in the Rizin's CCl output:

image

Originally posted by @XVilka in https://github.com/rizinorg/cutter/issues/2960#issuecomment-1148768300

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Qt frameworkUnicode encoding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Comments window implementation in Cutter (likely in src/gui/CommentsWidget.cpp or similar). Check how comments are fetched from Rizin and displayed via Qt's QString. The issue suggests that unescaped Unicode characters are not displayed; perhaps the string is being escaped before display. Look at the 'CCl' output of Rizin and compare with raw comment data. Ensure that the text is treated as UTF 8 and not as ASCII. Consider using QTextCodec or QString::fromUtf8. Refer to the linked issue #2960 for context.