rizinorg/cutter

Remove the use of `rz_cons_html_filter()` from Cutter

Open

#2,813 opened on Oct 19, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (14,852 stars) (1,123 forks)batch import
Help Wanted

Description

There is rz_cons_html_filter() call in src/core/Cutter.cpp that has output depending on the internal state of the RzCons. It should be substituted with reading the JSON output from rz_core_print_disasm_json() instead.

Contributor guide

Tech stack
cpp
Domain
security
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++Rizin API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
The issue is in src/core/Cutter.cpp. The function rz cons html filter() should be replaced by obtaining JSON output from rz core print disasm json(). Investigate how to call rz core print disasm json() and parse its JSON result to extract the disassembly data. Look at existing usage of similar functions in the codebase for guidance. Check comments on the issue for any additional context. The goal is to ensure the output is consistent without relying on internal console state.
Remove the use of `rz_cons_html_filter()` from Cutter · rizinorg/cutter#2813 | Good First Issue