rizinorg/cutter

Remove the use of `rz_cons_html_filter()` from Cutter

Open

#2,813 opened on Oct 19, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)C++ (1,123 forks)batch import
Help Wanted

Repository metrics

Stars
 (14,852 stars)
PR merge metrics
 (Avg merge 13d 23h) (20 merged PRs in 30d)

Description

There is rz_cons_html_filter() call in src/core/Cutter.cpp that has output depending on the internal state of the RzCons. It should be substituted with reading the JSON output from rz_core_print_disasm_json() instead.

Contributor guide

Research direction
Examine the current call to rz cons html filter() in src/core/Cutter.cpp and understand its output. Then, find the output of rz core print disasm json() and replace the call with parsing that JSON to achieve the same result.
Tech stack
cpp
Domain
desktop
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70