rizinorg/cutter

asm.lines.fcn doesn't work

Open

#2190 opened on May 10, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (14,852 stars) (1,123 forks)batch import
BUGHelp WantedUI

Description

Environment information

  • Operating System: ArchLinux
  • Cutter version: 1.10.3
  • Obtained from:
    • Built from source
    • Downloaded from release
    • Distribution repository
  • File format: x86_64 ELF

Describe the bug

Cutter settings contain option "Show function boundary lines (asm.lines.fcn)" but it gets ignored. DisassemblyWidget sets set("asm.lines", false); when retrieving disassembly, this was probably added when switching from ascii arrows to drawing arrows in cutter.

To Reproduce

Steps to reproduce the behavior:

  1. Open Cutter
  2. Observe that "Show function boundary" but there is no function boundary indicator
  3. Disable "Show function boundary", observe that nothing changes
  4. Enable "Show function boundary", still no function boundary indicator

Expected behavior

When asm.lines.fcn is true function function boundaries are visualized.

Screenshots

Additional context

Contributor guide

Tech stack
cpp
Domain
desktoptooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Qt
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug is caused by a forced `set("asm.lines", false);` in the DisassemblyWidget code that overrides the user's `asm.lines.fcn` setting. Locate the file containing that widget and modify it to respect the `asm.lines.fcn` configuration. Ensure that when `asm.lines.fcn` is enabled, the function boundary lines are drawn as expected.