rizinorg/cutter

Paletize the Cutter color themes

Open

#2138 opened on Apr 10, 2020

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C++ (14,852 stars) (1,123 forks)batch import
UIgood first issue

Description

Is your feature request related to a problem? Please describe.

Qt stylesheets support using the colors from current QPallete https://doc.qt.io/qt-5/stylesheet-reference.html#paletterole .

Reasons for using color palette and palette roles in the color theme stylesheets

  • less places that need to updated when adjusting color
  • might allow simplifying the stylesheets in places where the widgets would use those colors from palette by default
  • Dark and midnight theme stylesheets are almost identical except colors. With color palette they can probably be deduplicated thus reducing amount of work for fixing stylesheet related layout bugs.
  • easier future theme creation by customizing only palette

Describe the solution you'd like

  • Fully specify the color palettes for the existing cutter themes, currently only text color is set
  • Replace use of explicit colors in theme stylesheets with palette roles as much as possible
  • try if parts of stylesheet can be simplified due to use of palette color being the default behavior
  • evaluate if some of the themes can share stylesheet

Describe alternatives you've considered

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Qt stylesheetsC++ programmingColor palette concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Examine the existing theme stylesheets in the Cutter repository (likely under src/ or resources/). Refer to Qt documentation on QPalette and stylesheet syntax. The issue suggests deduplicating themes by using palette roles; investigate which colors are currently hardcoded and can be replaced. No linked PRs or assignees, so the work is available.