rizinorg/cutter

Useless asm.lines option in settings

Open

#1964 opened on Dec 21, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (14,852 stars) (1,123 forks)batch import
QuestionUIgood first issue

Description

Environment information

  • Operating System: Any
  • Cutter version: 1.10
  • File format: Any

Describe the bug

Settings currently contains "Show jump lines (asm.lines)" option. Since Cutter has it's own mechanism for drawing them this option currently does nothing.

Expected behavior

One of the two:

  • Show jump lines affects jump lines drawn by Cutter
  • Show jump lines option is removed from Cutter settings

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++ basicsQt framework knowledgefamiliarity with Cutter settings
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the settings dialog implementation in Cutter (likely using Qt UI forms). Find the checkbox for 'Show jump lines' and trace its connection to the asm.lines configuration. Since the option has no effect, either remove the checkbox and related code, or implement the intended behavior by linking it to the jump line drawing in the disassembly view. The issue has been open since 2019 with no clear consensus; consider opening a discussion to decide which approach to take.