rizinorg/cutter

Cutter doesn't preserve Graph Layout after reset

Open

#1,704 opened on Aug 10, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C++ (14,852 stars) (1,123 forks)batch import
BUGGraphHacktoberFestgood first issue

Description

Environment information

  • Operating System: Any
  • Cutter version: latest - master
  • File format: Any

Describe the bug

There are actually two related bugs:

  1. When changing the graph layout to another layout and restarting Cutter. The graph layout is back to its default value. Cutter should preserve the user's preferences.
  2. After changing the graph layout and clicking "Reset Settings", the layout stays changed until Cutter is re-opened. I'd expect the layout to be reset to its default layout when resetting settings and don't wait for the restart to take effect.

To Reproduce

Scenario 1: 0. Open a binary in Cutter

  1. Open the Graph widget
  2. Right-click on the graph, and select a layout from the Layout context item. e.g "Graphviz polyline LR"
  3. Exit Cutter
  4. Re-open Cutter and go to the graph widget
  5. See that the graph returned to its default layout

Scenario 2: 0. Open a binary in Cutter

  1. Open the Graph widget
  2. Right-click on the graph, and select a layout from the Layout context item. e.g "Graphviz polyline LR"
  3. See that the graph layout has changed
  4. Now select "View -> Reset Settings" from the main toolbar
  5. Inspect that the graph did not change to its default layout
  6. Restart Cutter and open a binary. See that the layout returned to default Steps to reproduce the behavior:
  7. Go to '...'
  8. Click on '....'
  9. Scroll down to '....'
  10. See error

Expected behavior

The chosen layout should be saved in Settings, preserved in each execute of Cutter, and return to its Default layout when the settings are reset.

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The bug is in the graph widget settings persistence. Investigate how graph layout is saved in settings (likely using QSettings) and why it is not preserved across restarts or reset. Look at the GraphWidget class and the reset settings action handler. The expected behavior is that the layout should be stored in the application settings and restored on startup, and resetting settings should revert to default immediately.
Cutter doesn't preserve Graph Layout after reset · rizinorg/cutter#1704 | Good First Issue