rizinorg/cutter

Improve edit function

Open

#1,576 opened on May 21, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C++ (14,852 stars) (1,123 forks)batch import
Enhancementgood first issue

Description

  • stack size -> stackframe size
  • [ ] button to edit variables and arguments
  • edit xrefs and refs
  • edit function signature (afs command) #1643
  • Edit function VS edit->function

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C++ programmingQt framework basicsUnderstanding of function editing in CutterFamiliarity with the codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Start by examining the current edit function code in Cutter's source, likely in the Dialogs or Widgets directory. Understand how the existing UI shown in the screenshots is implemented. Look at the referenced issue #1643 for function signature editing via 'afs' command. Investigate the difference between 'Edit function' and 'Edit >function' actions. Then design and implement the required changes: rename 'stack size' to 'stackframe size', add buttons for editing variables/arguments, and enable editing of xrefs and refs. No maintainer comments are present, so proceed based on the issue checklist. Consult the codebase structure and existing editor dialogs for patterns.