rizinorg/cutter

Add a shortcut for text search dialog on Disassembly and Graph

Open

#1298 opened on Mar 16, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (14,852 stars) (1,123 forks)batch import
DisassemblyEnhancementGraphHacktoberFestUIgood first issue

Description

Is your feature request related to a problem? Please describe.

A shortcut is missing for launching text search dialog on Disassembly and Graph

Describe the solution you'd like

Quick text search by doing Ctrl-F

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++QtCMakebasic Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate how existing shortcuts are implemented in Cutter. Likely use QShortcut or QAction shortcuts. Check files like 'src/core/MainWindow.cpp' and search for 'shortcut' or 'Ctrl+F' references. The Disassembly and Graph views are implemented in 'src/gui/DisassemblyWidget.cpp' and 'src/gui/GraphWidget.cpp'. Add a QShortcut with key sequence Qt::CTRL + Qt::Key F and connect to the text search dialog method. Ensure the shortcut is only active when the respective widget has focus.