ritz078/embed-js

YouTube plugin not correctly parsing full urls

Open

#267 opened on Aug 9, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,262 stars) (95 forks)batch import
bughelp wanted

Description

Using the YouTube plugin the url https://www.youtube.com/watch?v=example&t=6s is not parsed correctly.

The only part passed is youtube.com/watch?v=example leaving the embedded video wrapped in https:// and &t=6s

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScript basicsURL parsing concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the YouTube plugin source code in the repository, likely in a file specific to YouTube embeds. The issue mentions that the URL 'https://www.youtube.com/watch?v=example&t=6s' is parsed incorrectly, with only 'youtube.com/watch?v=example' being extracted. Check the regex or string splitting logic used to extract the video ID. A potential fix would involve adjusting the parsing to retain the full URL or correctly handle query parameters. The issue has been open since 2018 with no activity, so consider updating dependencies or confirming the bug still exists.
YouTube plugin not correctly parsing full urls · ritz078/embed-js#267 | Good First Issue