ritz078/embed-js

Link containing '@' is not rendered correctly

Open

#257 opened on Oct 31, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,262 stars) (95 forks)batch import
enhancementhelp wanted

Description

Hi, when rendering a link like "https://some.com/#/something@some.com", the result is strange, as shown in picture[1], and the html is in picture[2], thank you.

[1] result

[2] html-result

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with JavaScriptbasic understanding of URL parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the URL rendering module, likely in a file handling link parsing. Check for regex patterns that split at '@' or similar. Look at the HTML output to identify how the link is being broken. Since it's a JavaScript plugin, the parsing might be in src/index.js or similar. Review any existing tests for URL rendering.
Link containing '@' is not rendered correctly · ritz078/embed-js#257 | Good First Issue