rigor789/vue-scrollto

v-scroll-to breaks HTML5 form validation with Enter

Open

#155 opened on Sep 9, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,966 stars) (114 forks)batch import
help wanted

Description

Problem

If a HTML form has a button with v-scroll-to, that breaks form validation which occurs when a user presses Enter.

Steps to reproduce

  1. Open jsfiddle at https://jsfiddle.net/semenov/ukt84qvy/7/
  2. Type something in input 1, press Enter. The form validation for input 2 will NOT kick in, instead the page will be scrolled to a seemingly random (?) location:
  1. Edit jsfiddle, remove v-scroll-to, re-run it.
  2. Type something in input 1, press Enter. The form validation for input 2 WILL kick in, and the page will be scrolled to show input 2:

Expected behavior

Regardless of v-scroll-to, pressing Enter in a form scrolls to the input element that doesn't pass validation.

Contributor guide

Tech stack
javascriptvue
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Vue.js basicsHTML form events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is that the v scroll to directive intercepts the Enter key press event, preventing the form's default validation behavior. Investigate the directive's event handler in the source code (likely in src/index.js or similar). The fix should ensure that the directive only triggers scrolling when the click event comes from a button/input not in a form submission context, or delegate to the form's submit event. The jSFiddle provides a minimal reproduction.