Doc string for SQISW contains typos (unitary is incorrect)

Open Beginner friendly
#1,721 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
documentation

Research direction

Start in pyquil/simulation/matrices.py around the SQISW doc string linked in the issue, then inspect the generated API documentation to compare formatting. Correct the SQISW formatting and missing third-row elements, and fix “conditonal” in the FSIM and PHASEDFSIM doc strings. Done means the source and rendered documentation show the corrected descriptions.

Written by the indexing model from the issue text.

Description

bug :bug:

Pre-Report Checklist

  • [ X] I am running the latest versions of pyQuil and the Forest SDK
  • [ X] I checked to make sure that this bug has not already been reported

Issue Description

The doc string for the SQISW gate in pyquil.simulation.matrices has some issues:

  • the formatting is not correct,
  • elements are missing from the 3rd row of the unitary.

There is also a typo in the word "conditonal" in the phrase "XX+YY interaction with conditonal phase on |11>" which appears in the doc string for both the FSIM and PHASEDFSIM gates.

How to Reproduce

Check the source code or the documentation artifacts. The latter is the easiest way of seeing the problems (as the documentation is nicely formatted).

Dominant language
Python
Stars
1.5k
Forks
358
Avg merge
1d 58m
Merged PRs (30d)
4

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rigetti/pyquil

All issues in rigetti/pyquil

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.