rhiever/datacleaner

ValueError instead of TypeError in Python 2.7

Open

#10 opened on Feb 27, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (1,040 stars) (211 forks)batch import
bughelp wanted

Description

The try except block starting at line 76 of datacleaner.py raises a ValueError in Python 2.7 when the column is of type object (string). Since the Python 2.7 icon is displayed in the repo markdown, can you clarify which Python version is supported?

Contributor guide

Tech stack
python
Domain
data
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic Pythonunderstanding of exceptions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Examine datacleaner.py around line 76 to confirm the ValueError is raised for string columns in Python 2.7. Investigate the appropriate exception type (TypeError) and adjust the except clause accordingly. Note the repository may support Python 2.7 based on the icon, but clarify this in the issue. Review the 5 comments for any maintainer input on Python version support.