rhiever/datacleaner

ValueError instead of TypeError in Python 2.7

Open

#10 opened on Feb 27, 2017

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (211 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,040 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The try except block starting at line 76 of datacleaner.py raises a ValueError in Python 2.7 when the column is of type object (string). Since the Python 2.7 icon is displayed in the repo markdown, can you clarify which Python version is supported?

Contributor guide

Research direction
Inspect the try except block in datacleaner.py line 76 and identify where ValueError is incorrectly used instead of TypeError. Ensure the fix works under Python 2.7.
Tech stack
python
Domain
data
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80