revault/revault_tx

Exhaustive parsing checks

Open

#68 opened on Feb 27, 2021

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Rust (7 forks)auto 404
enhancementgood first issuehigh prio

Repository metrics

Stars
 (15 stars)
PR merge metrics
 (PR metrics pending)

Description

Right now, we only sanity-check the PSBTs in from_psbt_serialized() are sane with regard to our internal assumptions (unwrap()s basically). This may be enough, but we may also want complete parsing checks to be sure that whether a transaction is parsed or created with the constructor it will hold to our requirements (eg, no dust amounts, sane feerate, etc..). This is quite some more hairy code though..

Contributor guide

Research direction
Implement exhaustive parsing checks in from psbt serialized() to validate PSBTs against internal constraints such as no dust amounts, sane feerate, etc. This involves adding validation logic for each field of the PSBT according to the project's requirements.
Tech stack
rust
Domain
backendblockchain
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30