revault/revault_tx

Port (some of) the signature checker tests removed from `revaultd`

Open

#114 opened on Oct 29, 2021

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Rust (7 forks)auto 404
good first issuetests

Repository metrics

Stars
 (15 stars)
PR merge metrics
 (PR metrics pending)

Description

We lately removed a bunch of logic for checking signatures from revaultd (https://github.com/revault/revaultd/pull/284, https://github.com/revault/revaultd/pull/305). This logic was pretty well tested and some parts might be good additions to this repo's logic tests.

Contributor guide

Research direction
Port the existing signature checker tests from revaultd's repository, specifically the tests in the relevant pull requests (PR #284 and #305). Review the test logic and adapt them to revault tx's test framework.
Tech stack
rust
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
RustBitcoin scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60