rev087/ng-inspector

Replacing scope object with primitive does not update correctly

Open

#138 opened on Sep 23, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (787 stars) (100 forks)batch import
bughelp wanted

Description

(Here's a minimal example Plunkr.)

When a scope object is replaced with another object, the inspector version is replaced immediately and correctly. However, when an object is replaced with a primitive, some components still reference the old object:

  • If the property drop-down is open, the only visible change is the type icon. Otherwise in all ways, the inspector shows the old object. screen shot 2015-09-23 at 3 21 55 pm
  • If the property drop-down is closed, the primitive value is shown, however the property count is still visible, and the drop-down can be opened, leading to the above case.
  • In both situations, clicking the name or value will print the old object to the console.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontenddeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AngularJS basicsbrowser extension development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the inspector's scope watch mechanism in the source code. Look for how the inspector updates when scope values change, specifically when transitioning from object to primitive. The Plunkr example can be used to reproduce. Check if there is a missing check for primitive values in the update logic.