rev087/ng-inspector

Further issues barring entrance to the Mozilla Add-ons gallery

Open

#113 opened on May 26, 2015

View on GitHub
 (8 comments) (0 reactions) (0 assignees)JavaScript (787 stars) (100 forks)batch import
firefoxhelp wanted

Description

Your version was rejected because of the following problems:

  1. Dynamic creation of script nodes can be unsafe if contents are not static or are otherwise unsafe, or if src is remote. ng-inspector/data/inject.js 5
  2. The "mouseover", "mouseout" events are dispatched with high frequency and can cause performance issues. Use mutation observers instead https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver

Tested on Ubuntu 14.04 with Firefox v38

  1. is debatable, although we do create a script node, the contents are static and are not remote. What they consider unsafe exactly might be the bigger issue.
  2. could be solved by either the suggested method, or better yet (imo) using delegate events, which is a long overdue optimization either way.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic JavaScriptBrowser extension concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine ng inspector/data/inject.js line 5 to understand the dynamic script node creation. The content is static and not remote, so consider if any change is necessary or if the Mozilla reviewer's concern can be addressed with a comment. For the second issue, replace mouseover/mouseout events with MutationObserver or event delegation. Review the current event handling in the codebase and implement the chosen approach. Check the issue comments for maintainer insights on preferred solution.