Fail to destroy VM having Ceph/RBD volumes

Open
#665 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
backend, infrastructure

Research direction

Start in instances/views.py at destroy, then follow delete_all_disks and refresh_instance_pools in vrtManager/instance.py, especially the get_pool_by_target(target_path).refresh(0) call. Reproduce destruction for a VM with a Ceph/RBD disk and trace the pool lookup. Done means the VM can be completely destroyed without the NoneType refresh error.

Written by the indexing model from the issue text.

Description

When trying to completely destroy a VM I got "Error 500" and the following stracktrace in logs:

  File "/srv/webvirtcloud/instances/views.py", line 408, in destroy 
    instance.proxy.delete_all_disks() 
  File "/srv/webvirtcloud/vrtManager/instance.py", line 1257, in delete_all_disks 
    self.refresh_instance_pools() 
  File "/srv/webvirtcloud/vrtManager/instance.py", line 1420, in refresh_instance_pools 
    self.get_wvmStorages().get_pool_by_target(target_path).refresh(0) 
AttributeError: 'NoneType' object has no attribute 'refresh'

This is because the VM has a disk on Ceph/RBD.

Dominant language
JavaScript
Stars
1.9k
Forks
398
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from retspen/webvirtcloud

All issues in retspen/webvirtcloud

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.