restify/node-restify

Gzip plugin prevents text/event-stream from working

Open

#820 opened on Jun 2, 2015

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (983 forks)batch import
BugCriticalHelp WantedUnconfirmed

Repository metrics

Stars
 (10,695 stars)
PR merge metrics
 (Avg merge 3h 56m) (2 merged PRs in 30d)

Description

I have to call

      res.handledGzip && res.handledGzip();
      res.removeHeader('Content-Encoding');

in my SSE plugin to bypass the Gzip plugin—otherwise EventSource fails.

The solution would involve adding support for keep alive connection in the Gzip plugin.

Contributor guide

Research direction
Examine the Gzip plugin in restify and identify how to skip compression for text/event stream responses, possibly by checking the response content type or connection header.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsrestify
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60