restify/node-restify

serveStatic is non-intuitive

Open

#535 opened on Feb 18, 2014

View on GitHub
 (33 comments) (0 reactions) (0 assignees)JavaScript (983 forks)batch import
BugHelp WantedServe

Repository metrics

Stars
 (10,695 stars)
PR merge metrics
 (Avg merge 3h 56m) (2 merged PRs in 30d)

Description

KISS: Keep it simple stupid. Please make it this for static files plugins, all people have the same problem, in my ofice 5 persons give me the same as bug!!

if you assign this:

server.get(/\/docs\/public\/?.*/, restify.serveStatic({
  directory: './public'
}));

will mean that if you get the url "domain.com/docs/public" this will be load the content of "public" folder. END. Not at prefix for the entire route path... and your fairy tales... Kiss men, kiss...

Contributor guide

Research direction
Inspect the serveStatic middleware to understand how file paths are resolved from the route prefix. Compare the expected behavior with the actual path resolution.
Tech stack
javascriptnodejs
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65