restify/node-restify

[Docs Site] Remove search bar

Open

#1,539 opened on Oct 23, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (983 forks)batch import
CriticalDocsHelp Wanted

Repository metrics

Stars
 (10,695 stars)
PR merge metrics
 (Avg merge 3h 56m) (2 merged PRs in 30d)

Description

Site: http://restify.com/ Browsers tested:

  • Chrome (62.0.3202.62 (Official Build) (64-bit))
    • Chrome private browsing
  • Firefox Developer Ed.
  • Safari (Version 11.0 (11604.1.38.1.7)) OS: macOS 10.11.6 El Capitan

Repro steps:

  • Navigate to http://restify.com/ in your browser
  • Type text into searchbox in upper right
  • press enter/return on keyboard, or
  • click magnifying glass icon

unable to search docs with searchbox

Expected result:

  • search is initiated by pressing enter/return on keyboard while search input field is focused
  • search is initiated by clicking on magnifying glass icon

Actual result:

  • enter/return on keyboard does nothing - search not initiated

Contributor guide

Research direction
Inspect the search bar HTML and add event listeners for 'keydown' and 'click' to trigger the search action.
Tech stack
javascript
Domain
documentation
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Basic web development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85