restify/node-restify

maintenance branch releases accidentally blow away "latest" npm dist-tag

Open

#1,392 opened on Jun 29, 2017

View on GitHub
 (8 comments) (0 reactions) (1 assignee)JavaScript (983 forks)batch import
CriticalFeatureHelp Wanted

Repository metrics

Stars
 (10,695 stars)
PR merge metrics
 (Avg merge 3h 56m) (2 merged PRs in 30d)

Description

Currently on the 4.x branch (now a maintenance branch since 5.0.0 has been released), the make cutarelease target is used to tag and publish a new release. npm publish however will implicitly assign the 'latest' dist tag to this releae. We don't want that for 4.x, because 5.x releases should stay as the "latest".

Proposal: Use npm publish --tag=latest-4. Explicitly using a tag gets npm publish to not implicitly use 'latest'. I'm copying npm's own "latest-$majorver" pattern here:

$ npm info npm dist-tags

{ latest: '5.0.4',
  next: '5.0.4',
  'latest-2': '2.15.12',
  'next-2': '2.15.12',
  'latest-1': '1.4.29',
  lts: '2.15.11',
  'latest-3': '3.10.10',
  'next-3': '3.10.10',
  'latest-4': '4.6.1',
  'next-4': '4.6.1',
  'latest-5': '5.0.4',
  'next-5': '5.0.4',
  'v5.0-next': '5.0.4' }

@retrohacker Sound good?

Contributor guide

Research direction
Locate the `cutarelease` target in the Makefile or similar release scripts and modify the `npm publish` command to include ` tag=latest 4` to prevent overwriting the 'latest' dist tag.
Tech stack
javascriptnodejsshell
Domain
devops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gitnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60