Dockerfile COPY with multiple sources needs trailing slash

Open Beginner friendly
#286 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
docker
Domain
build-system

Research direction

Use the linked repository code search to locate the seven Dockerfiles containing COPY package*.json. Check each matching instruction against the Dockerfile source-file requirement, update the destination syntax consistently, and verify that all seven instances now use a trailing slash.

Written by the indexing model from the issue text.

Description

There are 7 instances in Dockerfiles in this repo:

https://github.com/search?q=repo%3Arestatedev%2Fexamples+Dockerfile+package*.json&type=code

Expected:

COPY package*.json ./

Actual:

COPY package*.json .

The requirement is:

https://docs.docker.com/reference/dockerfile/#source-1

If you specify multiple source files, either directly or using a wildcard, then the destination must be a directory (must end with a slash /).

There is no package-lock.json in these template folders, but anyone using these templates is likely to be bitten by this as soon as npm install generates a package-lock.json.

Dominant language
TypeScript
Stars
172
Forks
34
Avg merge
57m
Merged PRs (30d)
4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from restatedev/examples

All issues in restatedev/examples

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.